Skip to content

FOUR-24334: Error with PM Block element in modeler, "Call Activity must have child process selected" error - [45092]#1937

Merged
nolanpro merged 1 commit into
developfrom
defect/FOUR-24334
Aug 27, 2025
Merged

FOUR-24334: Error with PM Block element in modeler, "Call Activity must have child process selected" error - [45092]#1937
nolanpro merged 1 commit into
developfrom
defect/FOUR-24334

Conversation

@eiresendez

@eiresendez eiresendez commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

When adding a new PM Block element on the canvas, validation errors show up and then disappear when moving the element. "Call Activity must have child process selected" is incorrectly displayed as if the PM Block were corrupted.

Solution

  • Introduced a safeRevalidate method to centralize and properly time BPMN validation.
  • Trigger safeRevalidate to ensure validation runs correctly right after placement.
  • With this change:
    • PM Blocks can now be added to the flow without being flagged as corrupted.
    • The validation error no longer appears incorrectly on new PM Blocks.

How to Test

  1. Log into ProcessMaker.
  2. Open modeler.
  3. Enable Auto validate.
  4. Add a PM Block.
    • No validation error should be shown for the PM Block.

Related Tickets & Packages

…rrors consistent

- Introduced safeRevalidate method to handle validation after node placement
- Trigger safeRevalidate only on onNodeDefinitionChanged to ensure errors (e.g. Call Activity without child) remain visible
@cypress

cypress Bot commented Aug 20, 2025

Copy link
Copy Markdown

modeler    Run #1662

Run Properties:  status check passed Passed #1662  •  git commit 9f5a3ee116: FOUR-24334: Error with PM Block element in modeler, "Call Activity must have chi...
Project modeler
Branch Review defect/FOUR-24334
Run status status check passed Passed #1662
Run duration 05m 47s
Commit git commit 9f5a3ee116: FOUR-24334: Error with PM Block element in modeler, "Call Activity must have chi...
Committer Eleazar Resendez
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 83
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 280
View all changes introduced in this branch ↗︎

@mcraeteisha mcraeteisha self-requested a review August 20, 2025 19:41
@eiresendez eiresendez changed the title fix(modeler): add safeRevalidate on element drop to keep validation e… FOUR-24334: Error with PM Block element in modeler, "Call Activity must have child process selected" error - [45092] Aug 21, 2025
@processmaker-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nolanpro nolanpro merged commit 7dff329 into develop Aug 27, 2025
58 of 62 checks passed
@nolanpro nolanpro deleted the defect/FOUR-24334 branch August 27, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants